Add SetAuthentication function to authenticate 'passively'#516
Open
inteon wants to merge 1 commit intoVenafi:masterfrom
Open
Add SetAuthentication function to authenticate 'passively'#516inteon wants to merge 1 commit intoVenafi:masterfrom
inteon wants to merge 1 commit intoVenafi:masterfrom
Conversation
inteon
requested review from
EduardoVV,
luispresuelVenafi,
marcos-albornoz and
rvelaVenafi
as code owners
inteon
force-pushed
the
add_passive_auth_option
branch
from
6092cc1 to
0ee47ec
Compare
inteon
force-pushed
the
add_passive_auth_option
branch
from
0ee47ec to
131a524
Compare
|
@luispresuelVenafi / @rvelaVenafi / @marcos-albornoz / @EduardoVV - Any chance you might be able to review this PR from @inteon? |
inteon
force-pushed
the
add_passive_auth_option
branch
3 times, most recently
from
6824cf5 to
f32d0fd
Compare
inteon
commented
Jan 3, 2025
| apiKey string | ||
| accessToken string | ||
| verbose bool | ||
| Identity identity |
Contributor
Author
There was a problem hiding this comment.
Identity was not used anywhere.
inteon
commented
Jan 3, 2025
| apiKey string | ||
| accessToken string | ||
| verbose bool | ||
| user *userDetails |
Contributor
Author
There was a problem hiding this comment.
user was not meaningfully used anywhere.
inteon
force-pushed
the
add_passive_auth_option
branch
2 times, most recently
from
7e59ddb to
940ad3e
Compare
inteon
commented
Feb 20, 2025
| // 3. API key. Get user to test authentication | ||
| // 3. API key. Assign it to connector | ||
| c.apiKey = auth.APIKey | ||
| url := c.getURL(urlResourceUserAccounts) |
Contributor
Author
There was a problem hiding this comment.
This check has been replaced by the getUserDetails function which is called by Authenticate.
inteon
commented
Feb 20, 2025
| c.apiKey = resp.APIKey | ||
|
|
||
| if c.client != nil { | ||
| c.Identity, err = c.retrieveSelfIdentity() |
Contributor
Author
There was a problem hiding this comment.
These calls have been moved to the Authenticate function.
…ending a self-check request to the server) Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
add_passive_auth_option
branch
from
940ad3e to
f7f58a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using vcert as a library, being able to create a vcert client without sending a self-check request to the server can help reduce unnecessary API calls.
It gives the caller more control over when the self-checks occur.
Eg. when creating clients dynamically based on cached credentials.