[VPD-470]: Asset Migration from Core to Isolated E-Mode #661
+10,867
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art-1 verification Split risk parameter checks into per-market it blocks for better failure diagnostics. Add Part-1 pool verification and mint/borrow/repay/redeem tests to bscmainnet-2 simulation to ensure Part-1 pools remain correctly configured after Part-2 execution.
Remove async from describe callbacks and replace this.skip() with console.log + return so capped/paused markets pass with a message instead of showing as pending in Mocha output.
Use actual token decimals instead of hardcoded 18 for parseUnits calls, fix signer index allocation to avoid collisions with mint/borrow tests, replace hardcoded skip lists with dynamic supply-cap checks, extract findEvents helper to deduplicate log-parsing, remove unused swap signer setup and related dead code, and rename describe blocks to distinguish leverage tests from mint/borrow tests.
Track all skipped leverage positions (single-asset and cross-asset) during test execution and display a categorized summary table at the end of the test run. This makes it immediately clear in the CLI output which tokens had leverage flows skipped and why (supply cap exceeded, swap route unavailable, no position to exit, etc.).
- Refactor swap calldata builder to use Venus swap API instead of direct PancakeSwap V2 router calls, fixing swap route failures - Remove unused constants (USDT, WBNB, PANCAKE_V2_ROUTER, vUSDT_ADDRESS) - Hoist setupSwapSigner() to top-level before hook (runs once instead of per cross-asset pair) - Cache ethers.getSigners() once at top level, reuse in nested hooks - Add getCachedWhale() with Map cache around initMainnetUser to avoid redundant impersonateAccount and setBalance RPC calls - Pre-initialize all unique whale signers from MARKET_INFO in the top-level before hook - Cache testUser.getAddress() in single-asset leverage describe blocks
…in vip-800
- Add computeSafeFlashLoanAmount() that queries the resilient oracle to
compute ~$3 worth of borrow tokens (clamped 0.001–10), replacing the
hardcoded 0.01 flash loan amount that was too small for cheap tokens
(MATIC, DOGE, ADA) to produce viable DEX swaps
- Compute enterLeverageFromBorrow amounts dynamically using oracle prices
and collateral factor, replacing hardcoded values that exceeded borrowing
capacity for low-value collateral tokens (e.g. 20 DOGE at CF=0.43
could only borrow ~$0.69 but test tried to borrow 2 USDT)
- Compute exitLeverage redeem amount dynamically from vToken balance and
exchange rate (80% of underlying) instead of hardcoded value
- Parallelize oracle price reads and vToken balance/exchange rate reads
with Promise.all
- Mark "supply cap" errors as SKIPPED (external protocol constraint)
instead of FAILED across all catch blocks
- Remove "math error" and "cannot estimate gas" from skip conditions
so genuine failures surface correctly
- Refactor status assignment to use explicit isSkippable variable
- Create vips/vip-800/common.ts with shared vUSDT/vUSDC addresses, MarketConfig/EmodePool types, reusable stablecoin market configs, createEmodePool() factory, and generateEmodePoolCommands() helper - Simplify bscmainnet.ts from 290 lines to 38 lines by replacing repetitive pool config blocks with createEmodePool() calls - Simplify bscmainnet-2.ts from 260 lines to 36 lines similarly, using opts parameter for MATIC's differing liquidationThreshold - Re-export vUSDT/vUSDC from both files to preserve existing imports
- Use oracle-based dynamic amounts for collateral seeding (~$20 worth) and enterFromBorrow minting (~$50 worth) instead of fixed token amounts, preventing math errors on tokens with non-18 decimals (e.g., DOGE 8 dec) - Cap whale transfers by actual whale balance to avoid revert on insufficient funds - Seed borrow markets with ~$100 USD of liquidity for flash loans, wrapped in try/catch so supply cap or mint failures (e.g., vMATIC) don't crash the before() hook - Broaden error classification to skip (not fail) on "cannot estimate gas", "math error", "transfer amount exceeds", and "No API route" - Use gte instead of gt for vToken balance assertion in enterFromBorrow to handle zero-collateral-factor markets - Skip enterFromBorrow early when user has insufficient collateral
…testnet VIP-800 - Refactored bscmainnet.ts, bscmainnet-2.ts, bsctestnet.ts, bsctestnet-2.ts to use a shared createEmodePool and generateEmodePoolCommands API from common.ts. - Updated common.ts to remove hardcoded mainnet addresses and vToken configs, replacing with flexible factory functions for USDT/USDC market configs. - All VIP-800 files now pass the correct addresses and configs for their network, and generateEmodePoolCommands receives the correct Unitroller address. - Test files updated to verify both part-1 and part-2 pools, and to use the new pool config structure. - This unifies emode pool creation and proposal command generation logic across mainnet and testnet, reducing duplication and improving maintainability.
…m emode pool tests and logic - Removed PoolFallbackStatusUpdated event checks from all VIP-800 simulation tests for both mainnet and testnet. - Updated expected event counts in test assertions to match the new event sequence. - In common.ts, set allowCorePoolFallback to false for all Emode pools and removed the setAllowCorePoolFallback command from proposal generation. - Ensures Emode pools are created without core pool fallback and test coverage matches the new pool configuration.
Verify that isolated e-mode pools enforce market restrictions correctly in VIP-800 simulations. Tests cover three scenarios for both LINK and DOT pools: - Core pool behavior: users in pool 0 retain unrestricted access to all markets (supply, borrow, cross-collateral) including the e-mode asset - Isolated e-mode behavior: users who opt into an e-mode pool can only supply/borrow pool markets (asset + USDT + USDC), deposits to non-pool markets are allowed but borrows are rejected, and ETH-only collateral provides no borrowing power when allowCorePoolFallback is false - Mutual exclusivity: switching between core and e-mode pools correctly grants/revokes market access, and users cannot borrow from both pools simultaneously
Debugger022
force-pushed
the
feat/VPD-470
branch
from
23b3049 to
8514c5f
Compare
fred-venus
reviewed
Jan 29, 2026
fred-venus
reviewed
Jan 29, 2026
Debugger022
force-pushed
the
feat/VPD-470
branch
from
0aa05f9 to
8514c5f
Compare
- Remove MATIC e-mode pool (id 13) from VIP-800 configuration on both mainnet and testnet. Eliminate setPoolActive command from pool creation flow as pools are active by default while creation. - Renumber subsequent e-mode pools: - TRX: 14 → 13 - DOT: 15 → 14 - THE: 16 → 15 - Update simulation test to expect 15 events instead of 17, reflecting the removal of two setPoolActive calls (one for MATIC, one removed from the command generation).
fred-venus
reviewed
Jan 29, 2026
Merge bsctestnet and bsctestnet-2 files into unified testnet configuration for VIP-800: - Add vTRX (TRX market, pool ID 11, CF 0.6) - Add vTHE (THE market, pool ID 12, CF 0.53) - Update simulation event counts from 6 to 8 pools (event counts: 18→24 for most events, 6→8 for PoolCreated) - Remove bsctestnet-2.ts files after combining into main testnet VIP The combined file now includes all 8 e-mode pools (DOGE, AAVE, UNI, TWT, ADA, LTC, TRX, THE) with consistent USDT/USDC cross-asset support.
Contributor
Author
|
Testnet execution: https://venus-testnet.vercel.app/#/governance/proposal/653?chainId=97 |
- Fix mainnet-2 simulation event counts from [15,18,18,18,6,18] to [15,15,15,15,5,15] - Add default exports to bscmainnet, bscmainnet-2, and bsctestnet VIP files - Remove outdated vMatic comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the migration of several markets from the BNB
core poolto newly createdisolated e-modepools as part ofVPD-470. The migration is designed to enhance risk isolation and improve protocol safety by grouping assets into dedicated e-mode pools.Markets Migrated
The following markets have been migrated from the core pool to their respective isolated e-mode pools:
New E-Mode Pool Names
Each asset now has its own e-mode pool:
Note: Some of the above-listed markets are not present in the bsctestnet.
Note: USDT and USDC are also added to each new e-mode pool, alongside the primary asset, providing stablecoin support and enhancing pool utility.
Actions Performed for Each Market
For each new e-mode pool, the following actions are executed:
PR Structure
Due to the large number of commands and the complexity of the migration, the
VIPimplementation has been split into two parts:Testing
This separation ensures better maintainability and reviewability of the migration process