Skip to content

Fix phpstan error in Fetch class#938

Merged
VerifiedJoseph merged 3 commits into
mainfrom
fix-phpstan-error-in-fetch-class
Oct 27, 2025
Merged

Fix phpstan error in Fetch class#938
VerifiedJoseph merged 3 commits into
mainfrom
fix-phpstan-error-in-fetch-class

Conversation

@VerifiedJoseph
Copy link
Copy Markdown
Owner

@VerifiedJoseph VerifiedJoseph commented Oct 27, 2025

Fixes type error in use of curl_setopt_array

Line   backend/include/Fetch.php                                                                                                                                              
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  :38    Parameter #2 $options of function curl_setopt_array expects array{19913: bool, 52: bool, 10018: non-empty-string}, array{19913: true, 52: true, 10018: string} given.  
         🪪  argument.type                                                                                                                                                      
         💡  Offset 10018 (non-empty-string) does not accept type string.   

@VerifiedJoseph VerifiedJoseph self-assigned this Oct 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (636f249) to head (4cbd84e).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #938   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       276       276           
===========================================
  Files             38        38           
  Lines            938       917   -21     
===========================================
- Hits             938       917   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VerifiedJoseph VerifiedJoseph merged commit c8aa67c into main Oct 27, 2025
5 checks passed
@VerifiedJoseph VerifiedJoseph deleted the fix-phpstan-error-in-fetch-class branch October 27, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant