Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the Go client.Scheduler API to support “no-shell” job submission and monitoring workflows (submit + get stable job keys, submit + wait, wait by keys, get status by key, wait for running), while preserving existing SubmitJobs behavior and pretend-submission support.
Changes:
- Added higher-level Scheduler methods (
SubmitJobsAndReturnIDs,SubmitJobsAndWait,WaitForJobs,GetJobByKey,WaitForRunning) plusSubmitJobsOptionsand exportedErrDuplicateJobs. - Updated job environment handling to distinguish “absent stored env” vs “explicitly empty stored env”, with new tests.
- Added extensive client tests, compile-only compatibility tests, and package examples + design/spec docs for the new API.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
jobqueue/jobqueue_test.go |
Adjusts an env-related test to align with new nil-vs-empty env semantics. |
jobqueue/job.go |
Updates Job.Env() semantics to treat nil env as “fallback to current env” while preserving explicit empty env. |
jobqueue/job_test.go |
Adds coverage for distinguishing absent vs explicitly empty stored environments. |
client/client.go |
Introduces the new high-level Scheduler API methods/options and pretend-mode support for them. |
client/client_test.go |
Adds comprehensive integration + pretend-mode tests for new Scheduler API behavior. |
client/client_compat_test.go |
Compile-only tests to ensure existing downstream Scheduler usage continues to build unchanged. |
client/example_test.go |
Adds compilable usage examples demonstrating the new no-shell API. |
.docs/nowrap/* |
Adds specification, prompts, and phased implementation notes documenting the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.