Skip to content

Improve client#504

Merged
sb10 merged 12 commits into
developfrom
nowrap
Jun 19, 2026
Merged

Improve client#504
sb10 merged 12 commits into
developfrom
nowrap

Conversation

@sb10

@sb10 sb10 commented Jun 19, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 19, 2026 21:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the Go client.Scheduler API to support “no-shell” job submission and monitoring workflows (submit + get stable job keys, submit + wait, wait by keys, get status by key, wait for running), while preserving existing SubmitJobs behavior and pretend-submission support.

Changes:

  • Added higher-level Scheduler methods (SubmitJobsAndReturnIDs, SubmitJobsAndWait, WaitForJobs, GetJobByKey, WaitForRunning) plus SubmitJobsOptions and exported ErrDuplicateJobs.
  • Updated job environment handling to distinguish “absent stored env” vs “explicitly empty stored env”, with new tests.
  • Added extensive client tests, compile-only compatibility tests, and package examples + design/spec docs for the new API.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
jobqueue/jobqueue_test.go Adjusts an env-related test to align with new nil-vs-empty env semantics.
jobqueue/job.go Updates Job.Env() semantics to treat nil env as “fallback to current env” while preserving explicit empty env.
jobqueue/job_test.go Adds coverage for distinguishing absent vs explicitly empty stored environments.
client/client.go Introduces the new high-level Scheduler API methods/options and pretend-mode support for them.
client/client_test.go Adds comprehensive integration + pretend-mode tests for new Scheduler API behavior.
client/client_compat_test.go Compile-only tests to ensure existing downstream Scheduler usage continues to build unchanged.
client/example_test.go Adds compilable usage examples demonstrating the new no-shell API.
.docs/nowrap/* Adds specification, prompts, and phased implementation notes documenting the feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread jobqueue/job.go Outdated
Comment thread jobqueue/job.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread jobqueue/job.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Comment thread client/example_test.go
Comment thread client/example_test.go
Comment thread client/example_test.go
Comment thread client/example_test.go
@sb10 sb10 merged commit 127dc32 into develop Jun 19, 2026
3 checks passed
@sb10 sb10 deleted the nowrap branch June 19, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants