fix: resolve dart coverage package_config in pub workspaces - #1689
Open
AzazelSensei wants to merge 1 commit into
Open
fix: resolve dart coverage package_config in pub workspaces#1689AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Pub workspaces only write .dart_tool/package_config.json at the workspace root. Pass the package directory as packagePath so the coverage resolver walks up the same way dart does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
very_good dart test --coveragecrashes in a pub workspace because it opens.dart_tool/package_config.jsonrelative to the process cwd. Workspaces only write that file at the root.I pass the package directory as
packagePathso the coverage package usesfindPackageConfigand walks up, same as dart.Fixes #1683
Type of Change