test: avoid using ElementsMatch in unit tests

[vrutkovs]

Avoid using imprecise ElementsMatch - use Equal, so that the order would always be preserved

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/controller/operator/factory/reconcile/statefulset_pvc_expand_test.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset_pvc_expand_test.go:184">
P2: This assertion makes the test depend on `client.List` returning PVCs in a specific order, which is not guaranteed. The behavior under test already sorts internally; the verification list should stay order-insensitive.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: This assertion makes the test depend on client.List returning PVCs in a specific order, which is not guaranteed. The behavior under test already sorts internally; the verification list should stay order-insensitive.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At internal/controller/operator/factory/reconcile/statefulset_pvc_expand_test.go, line 184:

<comment>This assertion makes the test depend on `client.List` returning PVCs in a specific order, which is not guaranteed. The behavior under test already sorts internally; the verification list should stay order-insensitive.</comment>

<file context>
@@ -181,7 +181,7 @@ func Test_updateSTSPVC(t *testing.T) {
 		}
 		assert.NoError(t, cl.List(ctx, &pvcs, listOpts))
-		assert.ElementsMatch(t, o.expected, pvcs.Items)
+		assert.Equal(t, o.expected, pvcs.Items)
 	}
 
</file context>

Suggested change

	assert.Equal(t, o.expected, pvcs.Items)
	assert.ElementsMatch(t, o.expected, pvcs.Items)