peer review#3
Open
julianalg wants to merge 1 commit intoVince2007:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall your game has an outstanding story and vision but with user experience and code, there is a lot of room for improvement. On the programming side, you can make coding way easier for yourselves and people looking at your code by using more descriptive names of classes and buttons. From my own personal experience of working on your code, I had difficulties determining the placement in the story of the
PreLudeandMainMenuclasses because of their naming. Additionally, instead of creating a brand new class and copying functionality for each class, you can create a BaseScene abstract class which contains all of the important functionality and abstract off of it for each new scene. Finally, you often change the gameText in event listeners in classes and I believe that way it becomes much easier to track progress in the game story so instead you could just create a new child class of BaseScene and pass that gameText changes and relevant buttons there.For the user, you can change the user interface to make interacting and playing the game much easier, including expanding the user window and changing the way text is displayed. One possible way is putting the game text in a scroll view and having each part of the story appear line-by-line by clicking the next button. This way the user won't be immediately overwhelmed by a wall text when they open the game. You could also change the styling of the game to be black and use specific colors that could emulate the environment of Seven Guys and make the player more immersed.