Skip to content

Add runner tag option for GitLab CI#10

Merged
VincentGuyader merged 8 commits intomainfrom
codex/ajouter-un-choix-de-tag-pour-le-job-gitlab
Jun 6, 2025
Merged

Add runner tag option for GitLab CI#10
VincentGuyader merged 8 commits intomainfrom
codex/ajouter-un-choix-de-tag-pour-le-job-gitlab

Conversation

@VincentGuyader
Copy link
Copy Markdown
Owner

Summary

  • document using shiny_build as the runner tag for set_gitlab_ci
  • move NEWS entry to a new dev version
  • add unit test ensuring runner tags are inserted
  • allow specifying multiple tags in examples and docs

Testing

  • Rscript -e 'testthat::test_dir("tests/testthat")' (fails: Rscript not found)
  • Rscript -e 'devtools::document()' (fails: Rscript not found)

https://chatgpt.com/codex/tasks/task_e_6842e20b70648328a442b1ada3f8ff01

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for specifying GitLab runner tags in set_gitlab_ci(), updates documentation and examples, and adds tests and NEWS for the new feature.

  • Introduce a new tags parameter in set_gitlab_ci() for multiple runner tags
  • Update vignettes, README, and Rd documentation with usage examples
  • Add unit tests to verify tag insertion and update NEWS for the dev version

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vignettes/introduction.Rmd Added an example showing how to specify runner tags
tests/testthat/test-set_gitlab_ci.R Added a test for inserting multiple runner tags
man/set_gitlab_ci.Rd Updated usage and arguments to include tags
README.md Added tags example under GitLab CI configuration
README.Rmd Added tags example under GitLab CI configuration
R/set_gitlab_ci.R Implemented tags parameter and tag insertion logic
NEWS.md Moved entry to dev version and documented tags
Comments suppressed due to low confidence (2)

README.md:112

  • This example omits the 'path' argument, which will trigger an interactive prompt. For non-interactive usage, include 'path = ...' to avoid hanging.
set_gitlab_ci(tags = c("shiny_build", "prod"))

R/set_gitlab_ci.R:64

  • [nitpick] Indentation for the 'tags:' block is hardcoded. Consider capturing the indent level of the matched 'stage:' line and reusing it to preserve YAML structure in different CI templates.
tag_lines <- c("  tags:", paste0("    - ", tags))

Comment thread tests/testthat/test-set_gitlab_ci.R Outdated
Comment thread R/set_gitlab_ci.R
Repository owner deleted a comment from Copilot AI Jun 6, 2025
VincentGuyader and others added 8 commits June 6, 2025 19:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@VincentGuyader VincentGuyader force-pushed the codex/ajouter-un-choix-de-tag-pour-le-job-gitlab branch from 61dbf26 to 3a1e16b Compare June 6, 2025 18:30
@VincentGuyader VincentGuyader merged commit d117622 into main Jun 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants