Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances set_gitlab_ci() by ensuring the destination directory is created if it doesn't already exist before copying the .gitlab-ci.yml file.
- Adds a check for
dir.exists(path)and creates the directory withdir.create() - Emits a success alert when a new directory is created
Comments suppressed due to low confidence (2)
R/set_gitlab_ci.R:32
- Add a unit test to verify that
set_gitlab_ci()creates the destination directory when it does not exist, ensuring this new behavior is covered.
# Create the destination directory if it doesn't exist
R/set_gitlab_ci.R:29
- Update the function documentation to mention that it now automatically creates the target directory if it does not already exist.
set_gitlab_ci <- function(path) {
|
|
||
| # Create the destination directory if it doesn't exist | ||
| if (!dir.exists(path)) { | ||
| dir.create(path, recursive = TRUE, showWarnings = FALSE) |
There was a problem hiding this comment.
Suppressing warnings with showWarnings = FALSE may hide important errors; consider allowing warnings or checking the function result to detect failures.
Suggested change
| dir.create(path, recursive = TRUE, showWarnings = FALSE) | |
| success <- dir.create(path, recursive = TRUE) | |
| if (!isTRUE(success)) { | |
| cli::cli_alert_danger("Failed to create directory: {path}") | |
| stop("Directory creation failed. Please check the path and permissions.") | |
| } |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_gitlab_ci()creates destination directoryTesting
devtools::test()(fails: packagesattachment,dockerfilerandyesnonot installed)https://chatgpt.com/codex/tasks/task_e_6842de439bd88328a3969470b2c15e07