feat: rebuild dedede.ro in Astro 6 (parity-locked migration from Elde…#81
Open
ViorelMocanu wants to merge 2 commits into
Open
feat: rebuild dedede.ro in Astro 6 (parity-locked migration from Elde…#81ViorelMocanu wants to merge 2 commits into
ViorelMocanu wants to merge 2 commits into
Conversation
ViorelMocanu
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-platforms the live dedede.ro marketing site from Elder.js 1.7.5 + Svelte 3.57 + Rollup 2 to Astro 6 (SSG-first, TypeScript
strictest, SCSS viasass-embedded, pnpm). This is a re-platform, not a redesign — the goal was pixel-, function-, and SEO-fidelity to production, proven by an automated parity oracle. Deploys to Cloudflare Workers (Static Assets) with the contact form as an Astro SSR endpoint backed by Resend.Parity — all 6 Definition-of-Done criteria pass
getStaticPathspinned to exactly 3 slugs; 0 redirectsdataLayer)<head>(24 changes — all approved waivers);robots.txtidentical; sitemap 9 URLs matchpnpm verify5/5 (format · lint · typecheck · 44 unit · e2e) · knip 0 unused ·pnpm audit0 highFull report + before/after/diff gallery:
parity/REPORT.md.What changed
.astrocomponents, zero UI-framework islands — no@astrojs/svelte, no@astrojs/mdx). All interactivity stays vanilla JS inpublic/resources/script.js..astropages +index.astro+ one[slug].astrocatch-route whosegetStaticPaths()allow-lists exactly the 3 root-level articles.trailingSlash: 'always',build.format: 'directory'.blogcontent collection; the baredatefrontmatter is kept asz.string()(no coerce) to preservearticle:published_timebyte-for-byte.sideform.php+ SendGrid → Astro SSR endpointsrc/pages/api/contact.ts(prerender = false) + Resend, with zod validation + a hidden honeypot. The form UI, AJAX flow, UTM hidden fields, GDPR box, anddataLayerevents are preserved exactly (only the POST target changes).@astrojs/cloudflare(wrangler deploy— not Pages).passthroughImageService).pnpm verifygate orchestrator, the offline parity oracle underparity/tools/, ESLint flat + Prettier + Vitest + Playwright + axe + Lighthouse + knip + husky/commitlint, plusAGENTS.md/CODING_PRINCIPLES.md/CONTEXT.mdand ADRs underdocs/.Dependencies (pinned, security-vetted)
Runtime (5):
astro·@astrojs/cloudflare·@astrojs/sitemap·resend·sass-embedded. (zod ships viaastro:content/astro/zod.)Dev (~20): typescript, @astrojs/check, eslint + plugins, prettier-plugin-astro, vitest, @playwright/test, @axe-core/playwright, sharp (build-host OG image only), wrangler, husky, commitlint, knip, @lhci/cli.
pnpm audit --audit-level=highis clean — a transitivetmpHIGH was remediated via a pnpm override (→ 0.2.7); 2 dev-only moderates remain, off the production graph.Redirects
None — all 9 public URLs are byte-identical between the legacy site and the rebuild. (Any future URL change requires its own ADR + a 301.)
Approved deviations (7 waivers)
The rebuild is byte/pixel-exact except for these intentional, documented changes (register:
parity/WAIVERS.md):@TODOtwitter handles · absolute articleog:image·og:type=articleon articles · normalize/cookies/og:descriptiontoname=· sitemap<lastmod>+ drop deprecatedrel=prev/next+ manifeststart_url.og-image.jpgwith a real branded 1200×630 image (fixes broken social sharing on home + the 3 legal pages)..ServiceText .HighlightWCAG-AA contrast violation (scheme-aware; stays ≤ 0.1% so it needs no pixel-threshold exception).How to verify locally
Before merge / deploy (out-of-repo prerequisites)
RESEND_API_KEY/RESEND_FROM/CONTACT_TOin Cloudflare (Preview and Production) and verify the Resend sender domain. A missing binding is a runtime 500 on the contact form, not a build error.wrangler deploy(Workers), notwrangler pages deploy.astro previewis unsupported by the Cloudflare adapter — servedist/client/viaparity/tools/serve-static.mjsfor local preview.Out of scope (deliberately deferred to protect parity)
A cookie-consent banner (confirmed absent on the live site — analytics fire unconditionally on the 6 non-legal routes, matching live) and SVGO optimization of the large
servicii.svg/ hero SVG.Built in 36 hours via Claude Opus 4.8 Ultracode on semi-auto mode.