fix: keep MoE routing and rollout versions consistent - #57
Draft
0z5a wants to merge 7 commits into
Draft
Conversation
- select experts from FP32 router probabilities - validate routed, shared, and activated expert topology
- serialize optimizer mutation with rollout generation - reject future and excessively stale rollout versions
- preserve FP32 expert selection without ordering unused top-k slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two training consistency failures:
topk. Close probabilities could collapse into ties and select a different expert set from the FP32 router decision.Changes
apply_weight_update(version, callback)scheduler boundary shared by generation and optimizer updates.rollout_max_policy_lag; the compatibility default isrollout_interval - 1.NVIDIA L20 benchmark
Environment: NVIDIA L20 (SM89), PyTorch 2.11.0+cu128, CUDA 12.8, BF16, seed 3407, 20 warmups, 100 timed iterations on GPU5.
Mismatch compares the selected expert set against an FP32-softmax/FP32-top-k reference. The maximum additional probability storage in this portfolio is 4 MiB. Reproduction code and raw output are checked in under
benchmarks/training_consistency/andbenchmarks/results/.Validation
640 passed, 103 skipped116 passedin 3.40s41 passedInfraSWE commit
811bc775ed5b3a6ec853219245f3469f78818020validates the AstrAI system-path comparison cell. The refreshed candidate, acceptance, probe, and workload digests all match their checked-in source sets. The visible-evidence diagnostic ProjectFit remains 92.41/100 and BenchmarkTrust 97.40/100. Official scoring intentionally remains unresolved because the draft is unsealed and lacks five fresh-process replays, system-trace evidence, hidden probes, and a verified evidence manifest.Scope limits
The benchmark is a single-process router microbenchmark and the async tests use deterministic thread interleavings. This PR does not claim a long-running multiprocess training soak or official InfraSWE certification.