Skip to content

chore(lint): enable high-signal correctness checks - #118

Merged
Zoupers merged 2 commits into
VirtualBeingsResearch:mainfrom
Zoupers:chore/ruff-loop-closure-check
Jul 28, 2026
Merged

chore(lint): enable high-signal correctness checks#118
Zoupers merged 2 commits into
VirtualBeingsResearch:mainfrom
Zoupers:chore/ruff-loop-closure-check

Conversation

@Zoupers

@Zoupers Zoupers commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • enable Ruff B005, B023, B904, B905, and RUF006 in the default lint configuration
  • retain fire-and-forget asyncio tasks and cancel the Explore Lab startup task during shutdown
  • preserve exception causes, make zip() length assumptions explicit, and remove JSON code fences without str.strip() character-set semantics
  • add a regression test for fenced summary content and prevent loop-closure regressions like the duplicate restored alarm scheduling bug fixed in fix(alarm): prevent duplicate restored triggers #117

Validation

  • uv run --frozen ruff check src tests scripts apps/explore-lab/backend — passed
  • uv run --frozen mypy src — passed (139 source files)
  • affected root unit tests — 490 passed
  • Explore Lab branch runner tests — 20 passed
  • git diff --check — passed

Risks and compatibility

  • no public API or configuration compatibility changes
  • background task references are released on completion; Explore Lab now waits for startup-task cancellation during shutdown
  • externally supplied Chroma result arrays retain truncating zip(..., strict=False) behavior, while internal parallel arrays use strict=True

Checks not run

  • the complete repository pytest suite was not run locally; the directly affected root and Explore Lab suites were run

Related: #117

@Zoupers Zoupers changed the title chore(lint): detect loop variable closures chore(lint): enable high-signal correctness checks Jul 28, 2026
@Zoupers
Zoupers added this pull request to the merge queue Jul 28, 2026
Merged via the queue into VirtualBeingsResearch:main with commit f94ef66 Jul 28, 2026
7 checks passed
@Zoupers
Zoupers deleted the chore/ruff-loop-closure-check branch July 28, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant