fix(gui): scale progress bar value to 0.0-1.0 range#22
Merged
Conversation
ProgressBar expects 0.0..1.0 but received 0..100, clamping to 100% onany non-zero progress. Divide stored u16 percent by 100 before passing to egui::ProgressBar::new.
dkmstr
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the progress calculation in the
AppWindowimplementation. The progress value is now divided by 100.0, likely to convert it from a percentage (0-100) to a normalized value (0.0-1.0) for display or further computation.Root cause: progress was stored as a u16 in the 0..100 range but passed directly to egui::ProgressBar::new, which expects 0.0..1.0. Any non-zero value was clamped to 100%.
Fix: divide the stored value by 100 before passing it to the progress bar, so the actual percentage reported by the server (e.g. 75%) is displayed correctly.
AppWindowprogress calculation (crates/gui/src/window/client_progress.rs).DEV Explain
When launching a connection and the client/server cannot yet reach the target VM (IP change, service still preparing, etc.), the broker returns a retryable error with a percent field (e.g. 75%). The UDS Launcher was always rendering this as 100% in the progress bar.