Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change attempts to implement Bindings for Python Classes to JavaScript Classes allowing for newer implementations to arise.
Warning
There is however one key side-effect which is that passing Unicode attributes back and forth will crash the system which is why I am not currently ready for another public release yet. Soon as this bug is tracked down and resolved CYJS will have a 0.2.0 release.
Important
Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
quickjs-ng/quickjs#1317 (I'm about to close this issue as this problem has been resolved) Through the use of magic integers to restore the type objects needed.
Checklist