Improve compatibility with compose plugin and third party containers (like nextcloud-aio)#21
Open
Joly0 wants to merge 2 commits intoVladoPortos:mainfrom
Open
Improve compatibility with compose plugin and third party containers (like nextcloud-aio)#21Joly0 wants to merge 2 commits intoVladoPortos:mainfrom
Joly0 wants to merge 2 commits intoVladoPortos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on improving the usability and overal visuals of folders when containers in folders are managed by compose plugin or are third party (like for nextcloud-aio managed containers).
Comparision:
Before:
After:
As seen on the screenshots, the immich folder is no longer showing an update available, and instead shows "compose" with the icon thats used for the compose containers. Also for testing i added the webtop container to the nextcloud folder to show that updates are still correctly shown for compose folders with a single dockerman container in it that has an update (in that case webtop). For mixed folders, the label "mixed" is used, which correctly switches to "apply update" as seen in the "web services" folder which contains dockerman and compose containers.
Everything is untouched.
Should fix #13 though maybe the text could be white aswell, instead of green, but thats up for a debate.