Fix WebUI URLs showing about:blank#blocked when folder is collapsed#29
Open
JimboLodisC wants to merge 1 commit intoVladoPortos:mainfrom
Open
Fix WebUI URLs showing about:blank#blocked when folder is collapsed#29JimboLodisC wants to merge 1 commit intoVladoPortos:mainfrom
JimboLodisC wants to merge 1 commit intoVladoPortos:mainfrom
Conversation
DockerUtil::host() can return empty, causing [IP] token in WebUI URLs to be replaced with nothing (e.g., http://:8080). Browsers block this malformed URL as about:blank#blocked. PHP fix: use empty() instead of !isset() to catch empty string, and fall back to $_SERVER['HTTP_HOST'] when DockerUtil::host() fails. JS fix: safety net that detects broken http://:PORT URLs in parsed container info and injects window.location.hostname. Fixes VladoPortos#8, fixes VladoPortos#17, fixes VladoPortos#9. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
about:blank#blockedinstead of the container's web interfaceDockerUtil::host()can return empty, causing[IP]token in WebUI URLs to be replaced with nothing, producing malformed URLs likehttp://:8080$_SERVER['HTTP_HOST']whenDockerUtil::host()fails, and a JS-side safety net that detects and fixes broken URLs usingwindow.location.hostnameTest plan
http://IP:PORTURL instead ofabout:blank#blockedFixes #8, fixes #17, fixes #9.
🤖 Generated with Claude Code