Dedupe podcast episodes re-uploaded to YouTube in home feed - #485
Open
rejas wants to merge 1 commit into
Open
Conversation
Podcast episodes are also uploaded to YouTube (titled "Podcast <episode title>"), so both fetchers were surfacing the same episode as two separate feed entries — removeDuplicates only dedupes by post.id, and podcast/YouTube IDs never overlap. Adds a title-based cross-source dedup step that drops the YouTube upload when a matching podcast post is present in the same batch. If podcast content is disabled for the user, no podcast post reaches this step, so the YouTube upload is left untouched and still shows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Podcast <episode title>"), so both thepodcastandytfetchers were surfacing the same episode as two separate home-feed entries.FetcherUtilities.removeDuplicatesonly dedupes bypost.id, and podcast episode GUIDs / YouTube video IDs never overlap, so no existing dedup step caught this.removeYouTubePodcastDuplicates, called before the id-based dedup infetchAndProcessPosts. It normalizes titles (case, whitespace, dash variants, strips the"Podcast "prefix) and drops the YouTube post when a matching podcast post is present in the same batch."Folge 25: Danger Dan, die Heizhammer-Lüge entlarvt..."vs."Podcast Folge 25: Danger Dan, die Heizhammer-Lüge entlarvt...".Test plan
pnpm check:ts— cleanpnpm lint:fix— 0 errors (pre-existing unrelated warnings only)pnpm check(type check + spell check) — cleanpnpm test— 135 suites / 1041 tests passing, including new coverage forremoveYouTubePodcastDuplicates(match/no-podcast-present/non-YouTube-shaped-post cases)🤖 Generated with Claude Code