fix: deploy_image output was silently dropped (secret in output value) - #39
Merged
Conversation
GitHub Actions silently drops any job/step output whose value contains a secret (CONTAINER_REGISTRY_ENDPOINT here) -- confirmed in the #38 deploy run: "Skip output 'deploy_image' since it may contain secret." That made `needs.docker-build.outputs.deploy_image` empty in docker-push-deploy, so the sha-tagged push and both PATCH deploy calls were reading a blank image ref. Fix: stop routing it through $GITHUB_OUTPUT entirely and reconstruct `${{ secrets.CONTAINER_REGISTRY_ENDPOINT }}/my-docker-image:${{ github.sha }}` inline wherever it's used -- secrets and github.sha are both available directly in every job, no cross-job output needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fast-follow to #38. The very first deploy it triggered (run 32130766048) shows GitHub Actions dropping the
deploy_imagejob output:GitHub Actions silently withholds any job/step output whose value contains a secret (
CONTAINER_REGISTRY_ENDPOINTwas embedded indeploy_image). That leavesneeds.docker-build.outputs.deploy_imageempty indocker-push-deploy, so the sha-taggeddocker pushand bothPATCHdeploy bodies were reading a blank image reference.Fix: stop passing it through
$GITHUB_OUTPUTat all.secrets.CONTAINER_REGISTRY_ENDPOINTandgithub.shaare both directly available in every job already, so the image ref is reconstructed inline wherever it's needed instead of crossing the job boundary as an output.Note: that same deploy run also failed earlier at the Scaleway login step with a
404 api_key not_found— that's a separate, unrelated issue (the configuredSCALEWAY_API_KEYsecret doesn't correspond to a live Scaleway API key) that needs fixing on the Scaleway/secrets side, not in this workflow.Test plan
SCALEWAY_API_KEYis fixed on the Scaleway/secrets side firstprereleasepush shows bothdocker pushlines succeed and thePATCHbody contains a real image ref (not blank)