Conversation
* first pass at fixing km proc rate Co-authored-by: Khazak <joe.j.sommer@gmail.com>
…into shadowlands
The following bugged behavior will be applied to Sickle of the Lion: * Unaffected by mastery * Multiplied dynamically by Tiger's Fury + Carnivious Instincts * Further multiplied dynamically by only Tiger's Fury * Snapshots Adapative Swarm instead of dynamically applying * Procs twice on target to refresh and extend duration by 30%
…into shadowlands
* Fully re-test with 2pc and 4pc behavior with the latest PTR build * 2pc procs do not benefit from or consume Opportunity or Greenskins damage buffs * 2pc procs benefit from Opportunity CP buff * 2pc procs cannot trigger 4pc procs and will not build procs when the BtE buff is active * 2pc procs no longer benefit from Dreadblades CP generation * Triple Threat extra impact appears to be able to trigger Main Gauche
…#6351) * [Warlock] Destruction APL typo * Requested change from Azevara, corrects behavior to hold DSI for infernal when possible. * Correct shard cost reduction for Ritual of Ruin
* Remove accidentally added aoe target scaling * Silence some warnings
* [Warlock] Update T28 Destruction set behavior * Add TODO note about possible new buff to add
WARNING: this is a preliminary implementation using assumptions based on the spell data. Many things will need to be confirms once the trinket is actually available. TODOs: * confirm stat priority when stats are equal. for now assuming same as titanic ocular gland * 369544 has same data as the driver, but with the presumably correct -7 scaling effect. Confirm that the driver really is 367246 and that 369544 is an unreferenced placeholder spell for the correct scaling effect. * confirm that the buff spell only lasts 10s as spell data suggests. Because it is not a permanent aura, we have to execute the new buff every time update_buffs() is called. * confirm that the 10s period of effect #1 in the driver is the periodicity on which your highest stat is checks & the respective buff applied
* Use new Sayaad name in pet enum * Rename Succubus to Sayaad * Allow multiple Sayaad name options in parsing * Add Whiplash ability and finalize Sayaad * Update comment * Add PTR check to prevent issues with 9.1.5 q exit jweoifjwef=:
* Optimize Chiburstusage for Nightfae only a small gain but still a gain (https://www.raidbots.com/simbot/report/5F8ynqTwfK5yL8AVMTcfAk/simc) chiburst casted right after the initial FLS for more procs and prioritizing it above most other things to get more resets in general * Update apl_monk.cpp
Include the first sigil trinket into the prioritized trinkets.
* Fix Shard of Annihilation Crit Chance * Fix Shard of Annihilation Crit Damage Multipliers
…into New-build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.