[AND-5631] Adapter Logging Phase 2#154
Conversation
…etected (#153) Added MediationLogging for the case multiple app ids are detected AND-5648
…appOpenAd` nullable and add check for proper logging
Added log for rewarded water fall case
| ) | ||
|
|
||
| override fun showAd(context: Context) { | ||
| if (appOpenAd.canPlayAd()) { |
There was a problem hiding this comment.
@HuFangshuai @felixzhang0703
As we discussed in the meeting (Q1 workweek), I removed canPlayAd check here, so SDK can handle (if the ad is not ready, it can log properly).
Let me know if this will be a problem.
There was a problem hiding this comment.
Yes, agree. But current if (appOpenAd.canPlayAd()) { call can also log proper errors.
There was a problem hiding this comment.
Oh, really? I didn't know that. Nice catch!
IOS doesn't log for canPlayAd (but, SDK does log when SDK checks canPlayAd in play() call flow), so I removed this.
Do you think I should keep it then?
There was a problem hiding this comment.
I'd want to go with the same flow as IOS side (which I removed canPlayAD check).
HuFangshuai
left a comment
HuFangshuai
left a comment
There was a problem hiding this comment.
The target branch should be 7.7.4-release or similar branch. Normally we don't push code to main from this forked repo.
In adapter, we have {version}-release branch corresponding to each SDK release.
I thought we can use |
|
@HuFangshuai |
…leInterstitialAd Capture createInterstitialAd result in a local val so the nullable interstitialAd member no longer requires a smart cast inside the VungleInitializationListener callback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
3 participants
This commit will remove the canPlayAd check for AppOpen ad, and let SDK fails when ad is not ready to play properly.
Also, updated AppOpen and Interstitial property as nullable and added the proper check before
play.AND-5631