Emergency force-cancel, protocol health script, deprecation policy, event schema reference - #507
Merged
misrasamuelisiguzor-oss merged 2 commits intoAug 29, 2026
Conversation
…ation policy, event schema - treasury: admin-only force_cancel_settlement escape hatch for settlements stuck in Pending/OnHold with unreachable quorum (Closes WHEELBACK#457) - scripts/protocol-health.sh: off-chain aggregation of pending settlements, blocked addresses, and pause state across all contracts (Closes WHEELBACK#458) - CONTRIBUTING.md: document entrypoint deprecation policy and its interaction with abi-drift-check.yml (Closes WHEELBACK#459) - docs/event-schema.md: formal event schema reference derived from every env.events().publish() call site; fixes a real discrepancy found in invoice/README.md where reject_refund/refund_rejected were undocumented (Closes WHEELBACK#460) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VapsGRDxvezFWJ8R724RoH
|
@joel-metal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #457
closes #458
closes #459
closes #460
contracts/treasury/src/settlements.rs: addsforce_cancel_settlement, an admin-only emergency escape hatch that force-cancels a settlement stuck inPending/OnHoldwhen normalcancel_settlement/dispute-resolution quorum is unreachable. Deliberately narrow (single settlement by ID, no signer/threshold changes), emits a distinctsettlement_force_cancelledevent carrying the invoking admin, and documented as emergency-only in the treasury README (candidate for a future timelock gate if one lands).scripts/protocol-health.sh: off-chain aggregation script (styled likescripts/init-contracts.sh) reporting pending settlement count, blocked address count, and pause state across treasury/compliance/invoice/settlement-workflow. Chose off-chain over an on-chain aggregation entrypoint since none of this needs on-chain atomicity/composability — rationale is in the script's header comment. Pause state has no dedicated getter on any contract today, so it's derived via a harmless--send=nosimulated probe call per contract (documented in-script).CONTRIBUTING.md: new "Deprecating an entrypoint" section — mark-deprecated-first with a signal event, minimum one-minor-version notice period, actual removal only at that boundary, and how this interacts withabi-drift-check.yml.docs/event-schema.md: formal schema for everyenv.events().publish(...)call site across all four contracts (topics, data type, emitting entrypoint), derived directly from source. Found and fixed a real discrepancy along the way:reject_refund/refund_rejectedexisted incontracts/invoice/src/entrypoints/lifecycle.rsbut were entirely missing fromcontracts/invoice/README.md.Testing
Per-task instruction, test suites were intentionally skipped for this batch. No
cargo/stellartoolchain was available in this environment to runcargo test/clippy/fmt; changes were reviewed by hand against the existing code style and call patterns (append-only error enum, existing event/topic conventions, existing README table formats).