feat:ci(tooling): centralize version pins to prevent multi-file stale… - #517
Merged
misrasamuelisiguzor-oss merged 2 commits intoAug 31, 2026
Merged
Conversation
|
@YahKazo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize GitHub Actions version pins in a single source of truth and add a guard that fails if any workflow reintroduces a hardcoded copy of the same pinned values.
This prevents stale version drift like the Stellar CLI pin being updated in one workflow but left behind in another. The change keeps the repo’s CI toolchain and CLI versions synchronized while making future regressions easy to catch automatically.
Changes
Added versions.env as the single source of truth for:
RUST_VERSION
STELLAR_CLI_VERSION
Updated GitHub Actions workflows to load the values from that file instead of hardcoding them inline:
build.yml
init-smoke-test.yml
contract-size.yml
test.yml
fmt.yml
lint.yml
Added a workflow-version guard script:
check-workflow-version-pins.sh
Hooked that check into the local pre-commit flow:
.pre-commit-config.yaml
Updated the local tool validation script to read the same central version values:
check-tools.sh
closes #438
closes #434