fix: disable dispute voting UI after outcome is finalized - #556
Open
LockedTerminal wants to merge 1 commit into
Open
fix: disable dispute voting UI after outcome is finalized#556LockedTerminal wants to merge 1 commit into
LockedTerminal wants to merge 1 commit into
Conversation
Closes WHEELBACK#230 - Replace the bare conditional `{!resolved && <actions>}` with an explicit ternary that renders a 'Outcome finalized — voting is closed' notice when `dispute.outcome !== null`, ensuring the finalized state is actively communicated rather than silently absent. - Add `dispute-card--finalized` modifier class to the card so the finalized state can be styled (slight opacity reduction) and targeted in tests. - Add finalized notice CSS: .dispute-card__finalized-notice renders in a muted background pill; .dispute-card__finalized-icon for the checkmark. - Vote buttons are not rendered at all when resolved, preventing any accidental submission of a now-meaningless on-chain vote transaction. - Add DisputeVotingPanel.test.tsx with 9 tests covering: - vote buttons present when dispute is open - vote buttons absent when dispute is finalized - 'Outcome finalized' notice visible when resolved - OutcomeBadge shown with correct label (claimant / counterparty) - finalized notice has role=status for screen reader accessibility - dispute-card--finalized class present/absent as expected - mixed open+finalized dispute list renders correctly
|
@LockedTerminal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
{!resolved && <actions>}with an explicit ternary that renders a 'Outcome finalized — voting is closed' notice whendispute.outcome !== null, ensuring the finalized state is actively communicated rather than silently absent.dispute-card--finalizedmodifier class to the card so the finalized state can be styled (slight opacity reduction) and targeted in tests._
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.closes #454