Skip to content

UnicodePlots: fix grid rescaling issue #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjaap merged 1 commit into from
May 5, 2026
+9 −6
Merged

UnicodePlots: fix grid rescaling issue #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## [1.20.1] -
- `UnicodePlots`: fixed a grid rescaling issue

## [1.20.0] - 2026-04-30
- a `GridVisualizer` can now be indexed with a single index
- `UnicodePlots`: multiple plots are now displayed even without `Term` loaded, but only one by one
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "GridVisualize"
uuid = "5eed8a63-0fb0-45eb-886d-8d5a387d12b8"
version = "1.20.0"
version = "1.20.1"
authors = ["Juergen Fuhrmann <juergen.fuhrmann@wias-berlin.de>", "Patrick Jaap <patrick.jaap@wias-berlin.de>"]

[deps]
Expand Down
10 changes: 5 additions & 5 deletions ext/GridVisualizeUnicodePlotsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ function gridplot!(ctx, TP::Type{UnicodePlotsType}, ::Type{Val{2}}, grid)
resolution = ctx[:size] ./ (48, 24) ./ (layout[2], layout[1])
aspect = ctx[:aspect]

# ensure that legend fits
ncellregions = num_cellregions(grid)
nbregions = num_bfaceregions(grid)
resolution = (resolution[1], max(resolution[2], 5 + ncellregions + nbregions))

# rescale resolution
wx = ex[2] - ex[1]
wy = ey[2] - ey[1]
Expand All @@ -103,11 +108,6 @@ function gridplot!(ctx, TP::Type{UnicodePlotsType}, ::Type{Val{2}}, grid)
# we need an integer resolution
resolution = @. Int(round(resolution))

# ensure that legend fits
ncellregions = num_cellregions(grid)
nbregions = num_bfaceregions(grid)
resolution = (resolution[1], max(resolution[2], 5 + ncellregions + nbregions))

# create UnicodePlots.Canvas
CanvasType = UnicodePlots.BrailleCanvas # should this be a changeable parameter ?
canvas = CanvasType(
Expand Down
Loading