You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There was a leftover bug from previous PR in setupRabbit.py, relevant only when using "--presel VAR:sum LOW HIGH", in particular with the ":sum" to integrate the selected axis before doing the fakes, since the axis name was propagated to other parts without removing the ":sum" key.
This had no effect on the standard CI workflow so it wasn't noticed.
Then, I am updating scripts/plotting/makeDataMCStackPlot.py with a new option to allow the user to set the x axis label (currently it is automatically read from the histogram axis, but sometimes that name is just a dummy and not informative).
Also, when using --customFigureWidth the plot function should set automatic_scale=False to make the option effective.
about this last point, it shouldn't be needed to touch automatic_scale, but there is probably a bug in wums here [0], since "width_scale" should not appear in both the width and height items for the figure when automatic_scale = True (perhaps the correct line should read figsize=(width_scale * base_size * width, base_size * width )
I realised that "automatic_scale" is not already an existing key argument of plot_tools.makeStackPlotWithRatio, which is called by makeDataMCStackPlot.py.
Adding it requires touching wums to propagate it, so before doing that it would be actually better to clarify whether this line [0] is effectively a bug.
If it is, and I fix it, then there is no actual need to implement the automatic_scale key to make --customFigureWidth work properly(although it might still be useful to have "automatic_scale" configurable as a possibility).
This PR needs WMass/wums#26 to be merged, to implement the automatic_scale flag in plot_tools.makeStackPlotWithRatio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a leftover bug from previous PR in setupRabbit.py, relevant only when using "--presel VAR:sum LOW HIGH", in particular with the ":sum" to integrate the selected axis before doing the fakes, since the axis name was propagated to other parts without removing the ":sum" key.
This had no effect on the standard CI workflow so it wasn't noticed.
Then, I am updating scripts/plotting/makeDataMCStackPlot.py with a new option to allow the user to set the x axis label (currently it is automatically read from the histogram axis, but sometimes that name is just a dummy and not informative).
Also, when using --customFigureWidth the plot function should set automatic_scale=False to make the option effective.
figsize=(width_scale * base_size * width, base_size * width )[0] https://github.com/WMass/wums/blob/c7e8a11a136b4b9d0df1f6fcb21d6127a4feea72/wums/plot_tools.py#L40