fix(plugins): corrective pass on remaining #178 tool-name drift - #231
Open
asachs01 wants to merge 2 commits into
Open
fix(plugins): corrective pass on remaining #178 tool-name drift#231asachs01 wants to merge 2 commits into
asachs01 wants to merge 2 commits into
Conversation
Ran #178's confirmed-drift list (18 vendors) through parallel per-plugin fixes, each independently verified against real ground truth (server source, live gateway tools, or this repo's own tool-drift-audit.mjs) rather than trusting the audit's tables blindly. Result: 14 of the 18 were already fixed by prior PRs (#197, #198, #200, #201) — this pass found nothing to do there. Real remaining work: - rootly: full rewrite of 4 skills (postmortems, services, alerts, workflows) that documented a fictional API surface — the gateway routes rootly to the hosted mcp.rootly.com server, not the local repo, and several skills invented tool names that exist on neither. Also fixed api-patterns/incidents renames, added missing mcp__rootly__* frontmatter to both agents (previously undeclared, so neither agent could actually call Rootly), and reconciled README/CHANGELOG drift. - freshdesk, timezest, connectwise/manage: small residual drift the earlier bulk passes missed (a few shorthand references, one contradictory sentence from a naive token-swap). - kaseya/it-glue: the one confirmed-drift item was a false positive (the wrong name only ever appeared inside a "not X" warning) — but the live audit surfaced 4 real phantom "location" tools nearby that were never in scope of #178 and are fixed here too. Also fixed two plugins outside #178's original list, surfaced by re-running the fleet audit live during this pass: - kaseya/autotask: 2 fictional contract tools (recent addition from #212), including one instance the audit missed entirely. - mailprotector: 3 genuine renames; 6 of 9 audit-flagged names turned out to be real SDK field/enum names, not tool references — left untouched (verified against mailprotector-mcp source directly). Verified clean via `node scripts/tool-drift-audit.mjs`, `check-doc-references.mjs`, `check-tool-anchoring.mjs`, and `claude plugin validate .` — all pass. Refs #178
Satisfies the bump gate in Marketplace + plugin validation CI, which requires every plugin whose files changed to bump its own plugin.json version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ran #178's confirmed-drift list (18 vendors) through parallel per-plugin fixes. Each fix was independently verified against real ground truth (server source, live gateway tools, or this repo's own
tool-drift-audit.mjs) — not applied mechanically from the audit's tables.14 of the 18 were already fixed by prior PRs (#197, #198, #200, #201) — nothing to do there. Real remaining work:
postmortems,services,alerts,workflows) that documented a fictional API surface. The gateway routes rootly to the hostedmcp.rootly.comserver, not the local repo, and several skills invented tool names that exist on neither. Also fixedapi-patterns/incidentsrenames, added missingmcp__rootly__*frontmatter to both agents (previously undeclared — neither agent could actually call Rootly), reconciled README/CHANGELOG drift.Two plugins outside #178's original list, found by re-running the fleet audit live during this pass:
mailprotector-mcpsource directly.Verification
node scripts/tool-drift-audit.mjs --plugins . --servers ~/mcp --gateway ~/mcp/mcp-gateway— 0 real drift remaining (mailprotector shows 5 items the script flags as drift, confirmed false positives — real field/enum names the script can't distinguish from tool names)node scripts/check-doc-references.mjs— passnode scripts/check-tool-anchoring.mjs— passclaude plugin validate .— passNot in scope here (per #178's own scoping)
email-security/checkpoint-avanangovernance gap (largest undocumented-tools risk — zero docs, 1 irreversible-delete tool)pax8(needs a live token to verify; also has a separate CI hazard worth its own issue onpax8-mcp)Refs #178
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.