Skip to content

fix(plugins): corrective pass on remaining #178 tool-name drift - #231

Open
asachs01 wants to merge 2 commits into
mainfrom
fix/tool-name-drift-corrective-pass-178
Open

fix(plugins): corrective pass on remaining #178 tool-name drift#231
asachs01 wants to merge 2 commits into
mainfrom
fix/tool-name-drift-corrective-pass-178

Conversation

@asachs01

@asachs01 asachs01 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

What

Ran #178's confirmed-drift list (18 vendors) through parallel per-plugin fixes. Each fix was independently verified against real ground truth (server source, live gateway tools, or this repo's own tool-drift-audit.mjs) — not applied mechanically from the audit's tables.

14 of the 18 were already fixed by prior PRs (#197, #198, #200, #201) — nothing to do there. Real remaining work:

  • rootly — full rewrite of 4 skills (postmortems, services, alerts, workflows) that documented a fictional API surface. The gateway routes rootly to the hosted mcp.rootly.com server, not the local repo, and several skills invented tool names that exist on neither. Also fixed api-patterns/incidents renames, added missing mcp__rootly__* frontmatter to both agents (previously undeclared — neither agent could actually call Rootly), reconciled README/CHANGELOG drift.
  • freshdesk, timezest, connectwise/manage — small residual drift the earlier bulk passes missed.
  • kaseya/it-glue — the one confirmed-drift item was a false positive (only appeared inside a "not X" warning). The live audit surfaced 4 real phantom "location" tools nearby that were never in Tool-name drift audit: skills documenting tools their servers don't expose #178's scope and are fixed here too.

Two plugins outside #178's original list, found by re-running the fleet audit live during this pass:

Verification

  • node scripts/tool-drift-audit.mjs --plugins . --servers ~/mcp --gateway ~/mcp/mcp-gateway — 0 real drift remaining (mailprotector shows 5 items the script flags as drift, confirmed false positives — real field/enum names the script can't distinguish from tool names)
  • node scripts/check-doc-references.mjs — pass
  • node scripts/check-tool-anchoring.mjs — pass
  • claude plugin validate . — pass

Not in scope here (per #178's own scoping)

  • email-security/checkpoint-avanan governance gap (largest undocumented-tools risk — zero docs, 1 irreversible-delete tool)
  • The broader "undocumented tools" pass across the fleet
  • pax8 (needs a live token to verify; also has a separate CI hazard worth its own issue on pax8-mcp)

Refs #178


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Ran #178's confirmed-drift list (18 vendors) through parallel per-plugin
fixes, each independently verified against real ground truth (server
source, live gateway tools, or this repo's own tool-drift-audit.mjs)
rather than trusting the audit's tables blindly.

Result: 14 of the 18 were already fixed by prior PRs (#197, #198, #200,
#201) — this pass found nothing to do there. Real remaining work:

- rootly: full rewrite of 4 skills (postmortems, services, alerts,
  workflows) that documented a fictional API surface — the gateway
  routes rootly to the hosted mcp.rootly.com server, not the local repo,
  and several skills invented tool names that exist on neither. Also
  fixed api-patterns/incidents renames, added missing mcp__rootly__*
  frontmatter to both agents (previously undeclared, so neither agent
  could actually call Rootly), and reconciled README/CHANGELOG drift.
- freshdesk, timezest, connectwise/manage: small residual drift the
  earlier bulk passes missed (a few shorthand references, one
  contradictory sentence from a naive token-swap).
- kaseya/it-glue: the one confirmed-drift item was a false positive
  (the wrong name only ever appeared inside a "not X" warning) — but
  the live audit surfaced 4 real phantom "location" tools nearby that
  were never in scope of #178 and are fixed here too.

Also fixed two plugins outside #178's original list, surfaced by
re-running the fleet audit live during this pass:
- kaseya/autotask: 2 fictional contract tools (recent addition from
  #212), including one instance the audit missed entirely.
- mailprotector: 3 genuine renames; 6 of 9 audit-flagged names turned
  out to be real SDK field/enum names, not tool references — left
  untouched (verified against mailprotector-mcp source directly).

Verified clean via `node scripts/tool-drift-audit.mjs`,
`check-doc-references.mjs`, `check-tool-anchoring.mjs`, and
`claude plugin validate .` — all pass.

Refs #178
Satisfies the bump gate in Marketplace + plugin validation CI, which
requires every plugin whose files changed to bump its own
plugin.json version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant