feat(advanced-workflows): pilot ticket-triage-agent as a vendor-generic skill - #233
Open
asachs01 wants to merge 11 commits into
Open
feat(advanced-workflows): pilot ticket-triage-agent as a vendor-generic skill#233asachs01 wants to merge 11 commits into
asachs01 wants to merge 11 commits into
Conversation
…ool-map Found real, registered tool names in connectwise/manage/GOVERNANCE.md's VENDOR_TOOL_CONFIG listing (slug connectwise-psa) after the original search only checked for the double-underscore naming pattern borrowed from Autotask/HaloPSA and missed GOVERNANCE.md's cw_-prefixed names. Replaces 'not yet verified' placeholders with connectwise-psa__cw_* tool names and adds ConnectWise-specific gotchas (note visibility default, sole closure route requiring human approval, closure ordering, shared rate limit).
…ked blocked IT Glue tool names corrected to the unprefixed form (search_documents, create_document, update_document_section) per kaseya/it-glue/GOVERNANCE.md, which is authoritative and contradicts the itglue__-prefixed names in Conduit's docs. Also added publish_document to the IT Glue adapter since GOVERNANCE.md flags unpublished section edits as invisible to a human, which the adapter's stated purpose (deliver to a human) depends on.
…ool names Prior commit f2f9ce9 dropped the itglue__ vendor prefix, reading kaseya/it-glue/GOVERNANCE.md's bare classification-table keys (create_document, etc.) as the servable tool name. That table is an internal VENDOR_TOOL_CONFIG permission-tier lookup, not the wire-format name — Conduit's unified-router.ts prefixes every served tool with {vendor}__ unconditionally and rejects any inbound call without a __ separator. Restores itglue__search_documents, itglue__create_document, itglue__update_document_section, itglue__publish_document, and corrects the in-body note that previously told editors not to add a prefix.
…agent Task 3's _workflow-skill-template.md mandates a Source section citing agent-routine-catalog.astro provenance, right after 'What this does'. The Task 6 brief omitted it. Cites the ticket-dispatcher agent (autotask, Archetype B, 'the canonical archetype-B fit') plus the equivalent service-desk-ops agents the catalog lists for halopsa and connectwise-psa -- the same three PSAs psa-tool-map curates.
Add plugin.json and README.md for the advanced-workflows plugin, add its marketplace.json entry (new "automation" category), and regenerate the docs site's generated data. Also fixes docs/scripts/generate-plugins.ts's path derivation (derivePath/deriveVendor/pluginDir), which assumed every plugin nests under msp-claude-plugins/ — advanced-workflows is the first plugin family to live at the repo root instead. Verified byte-identical output for all 82 pre-existing plugin entries.
…t>/msp-claude-plugins/<vendor>/<vendor> nesting convention The advanced-workflows plugin (Task 3's templates, Tasks 4-6's three skills, Task 7's plugin.json/README) was placed one level too shallow, at <checkout-root>/advanced-workflows/advanced-workflows/ instead of nested under msp-claude-plugins/ like every other plugin in this repo (verified against halopsa, kaseya, etc.). That was a plan-authoring mistake, not a deliberate new pattern. - git mv the whole tree to msp-claude-plugins/advanced-workflows/advanced-workflows/ and remove the now-empty <checkout-root>/advanced-workflows/ parent. - Revert docs/scripts/generate-plugins.ts's Task 7 special-casing entirely (confirmed byte-identical to the pre-Task-7 commit) — once correctly nested, the plugin needs no generator changes at all. - Update marketplace.json's advanced-workflows entry source to ./msp-claude-plugins/advanced-workflows/advanced-workflows. Re-ran npm run generate (plugin + all 3 skills resolve correctly, and regenerated plugins.ts/og-image.png are byte-identical to before this fix — the two approaches converged on the same output, just one via the canonical mechanism), npm run build (162 pages, no errors), and the marketplace drift check (passed, 84 entries). All three green.
check-doc-references.mjs flags a slug-shaped name that isn't the skill's canonical <plugin>-<skill> id as a second, colliding id. Switch to prose titles (matching the msp-plugin-development convention's own worked example) rather than the compound canonical id — Conduit's own ingest overwrites frontmatter.name with the directory slug regardless, so this is purely this repo's own doc-reference-integrity concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
advanced-workflowsplugin:psa-tool-map,chat-delivery-adapters, andticket-triage-agentskills.docs/superpowers/specs/2026-09-01-generic-advanced-workflow-skills-design.mdanddocs/superpowers/plans/2026-09-01-generic-advanced-workflow-skills.md.msp-claude-plugins/advanced-workflows/advanced-workflows/, matching every other plugin's<vendor>/<vendor>convention.Test plan
npx tsx scripts/validate-skill-md.tspasses on all 3 SKILL.md files (green/green/yellow grades — yellow is expected for skills documenting mutating tool names, not a blocker)npm run generate && npm run buildsucceeds indocs/(162 pages, no errors)node scripts/check-marketplace-drift.mjs --base mainpassesconnectwise-psa__cw_*) look right againstconnectwise/manage/GOVERNANCE.mdNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.