Skip to content

fix(deps): ignore ip-address/undici in dependabot -- nested unreachable copies - #41

Merged
asachs01 merged 1 commit into
mainfrom
murph/npm-bundled-deps-dependabot-ignore
Aug 25, 2026
Merged

fix(deps): ignore ip-address/undici in dependabot -- nested unreachable copies#41
asachs01 merged 1 commit into
mainfrom
murph/npm-bundled-deps-dependabot-ignore

Conversation

@asachs01

@asachs01 asachs01 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Unlike other node-* repos in this fleet, node-immybot never had the standard ip-address ignore entry applied, and undici shares the identical shape. Both packages' Dependabot Security update jobs fail silently (security_update_not_possible, no PR ever opens).

Confirmed via package-lock.json: each is node_modules/npm/node_modules/<pkg> (ip-address@10.2.0, undici@6.27.0), nested inside npm's own bundled dependency tree -- npm ships bundleDependencies covering its entire tree, vendored/pre-resolved at publish time. Same mechanism already empirically verified via an overrides-pin test on node-ninjaone: undici in WYRE-AI/node-ninjaone#74, ip-address on 2026-08-06.

Adds ignore rules for both. The underlying GHSA alerts stay visible on the Security tab regardless.

Test plan

  • YAML validated
  • Confirmed via package-lock.json that both packages' occurrences are under node_modules/npm/, no reachable top-level path
  • Config-only change, no source/dependency changes

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…le copies in npm's bundled tree

Unlike other node-* repos in this fleet, node-immybot never had the
standard ip-address ignore entry applied, and undici shares the identical
shape. Both packages' Dependabot Security update jobs fail silently
(security_update_not_possible, no PR ever opens). Confirmed via
package-lock.json: each is node_modules/npm/node_modules/<pkg>, nested
inside npm's own bundled dependency tree, unreachable via any top-level
dependency management. Same mechanism already empirically verified via an
overrides-pin test on node-ninjaone (undici, WYRE-AI/node-ninjaone#74;
ip-address, 2026-08-06).

Adds ignore rules for both. The underlying GHSA alerts stay visible on
the Security tab regardless.
@asachs01

Copy link
Copy Markdown
Contributor Author

Reviewed (maintainer). Verified against real artifacts, not just the description — new case (never had the ip-address ignore before), checked independently:

  • Pulled package-lock.json directly and confirmed both claimed nested-npm-bundled paths at the exact versions: node_modules/npm/node_modules/{ip-address@10.2.0, undici@6.27.0}. Both match the same fleet-wide npm-bundled tree seen across the other 6 repos in this batch.
  • Top-level undici in this repo resolves to 6.28.0 (a real, reachable, already-patched copy) — confirms the nested 6.27.0 under npm/ is genuinely unreachable, not a duplicate of something a real override could already fix.
  • dependabot.yml-only diff, no source changes, CI green (test 20/22 + release), no branch protection (direct merge).

Verdict: approve

@asachs01
asachs01 merged commit 57f4536 into main Aug 25, 2026
4 checks passed
@asachs01
asachs01 deleted the murph/npm-bundled-deps-dependabot-ignore branch August 25, 2026 18:27
github-actions Bot pushed a commit that referenced this pull request Aug 25, 2026
## [1.0.4](v1.0.3...v1.0.4) (2026-08-25)

### Bug Fixes

* **deps:** ignore ip-address/undici in dependabot -- nested unreachable copies in npm's bundled tree ([#41](#41)) ([57f4536](57f4536)), closes [WYRE-AI/node-ninjaone#74](WYRE-AI/node-ninjaone#74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant