P0084 | Registration Flow Page#597
Merged
Saurabh186 merged 10 commits intodevelopmentfrom Apr 21, 2026
Merged
Conversation
…g page - Add registration NgRx state, actions, effects, and reducer to handle user sign-up - Create onboarding component to handle email verification code exchange and auto-login - Add /app/onboarding route with verification code processing and error handling - Update app component to exclude onboarding route from dashboard redirect logic - Consolidate website route checks into array and add /register to website routes list - Replace
|
PR review rate limit exceeded |
Saurabh186
requested changes
Apr 16, 2026
| @@ -0,0 +1,52 @@ | |||
| <div | |||
| class="min-h-screen bg-[#0d1117] flex flex-col items-center justify-center px-4" | |||
| @@ -0,0 +1,52 @@ | |||
| <div | |||
| class="min-h-screen bg-[#0d1117] flex flex-col items-center justify-center px-4" | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| class="min-h-screen bg-[#0d1117] flex flex-col items-center justify-center px-4" | |
| class="min-h-screen bg-color flex flex-col items-center justify-center px-4" |
…eholders, centered layout
… validation - Change query param from 'token' to 'onboarding_token' in onboarding flow - Move onboarding_token from Authorization header to request body - Add passwordStrength validator with 5 requirements: min length, uppercase, lowercase, number, symbol - Replace static password hint with dynamic checklist showing met/unmet requirements - Add visual feedback with checkmarks (teal) for met rules and X marks (gray) for unmet rules
…route guard - Add AngularFireAuth dependency to CanActivateRouteGuard - Import map and take operators from rxjs - Check memory token before redirecting when cookie is missing - Add Firebase authState observable as final fallback for authentication - Return UrlTree redirect only if all auth methods fail
…ard and update onboarding flow - Remove AngularFireAuthGuard and redirectUnauthorizedTo imports from routing - Replace AngularFireAuthGuard with CanActivateRouteGuard across all routes - Remove ProjectGuard from panel routes canActivate array - Update onboarding query param from 'onboarding_token' to 'token' - Refactor onboarding submission to dispatch login data to store when client settings available - Simplify onboarding success
- Delete ProjectGuard file and remove from layout routes canActivate array - Remove redirectUnauthorizedTo and authGuardPipe data from layout routes - Remove exchangeToken method from UsersService - Remove exchangeToken URL definition from users-urls
Saurabh186
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86d2mqfzc