fix: don't auto-expand the top group when browsing with no query - #112
Merged
Merged
Conversation
defaultExpandedKeys fell back to "highest-ranked season" even when there was no search query and no watch position to seed from — so landing on the All tab in grouped view with an empty search popped the top group open for no reason a user could point to. That fallback now only fires when a real query was typed; a bare browse listing leaves every group closed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDh4YmkPuAoxWtgicYcuJn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultExpandedKeys(src/util/resultGroup.ts) now only falls back to "highest-ranked season" when a real search query was given; a bare browse listing leaves every group closed. This is a sharedsrc/utilmodule, so both the TUI and web grouped views pick up the fix.Test plan
npx vitest run src/util/resultGroup.test.ts— updated existing cases and added coverage for the no-query/no-position browse casenpm run linton changed filesnpm run build) and verified in Chrome: All tab, grouped view, empty search — every group renders closed🤖 Generated with Claude Code