chore(build): Find QuaZip library #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
xref #61 |
5 tasks
effigies
force-pushed
the
build/find-quazip
branch
2 times, most recently
from
7800cef to
e2d5c38
Compare
effigies
force-pushed
the
build/find-quazip
branch
from
e2d5c38 to
5437d49
Compare
Contributor
Author
|
I've confirmed this works on Fedora and conda-forge, as well as Ubuntu when stacked with #89. |
Member
|
This looks like debian has gone in a similar direction with the cmake scripts: https://packages.debian.org/sid/amd64/libquazip1-qt5-dev/filelist The debian build logs say it is using the in-source version of quazip at the moment, so perhaps the existing quazip detection code was just aspirational. @johnvelab @yarikoptic any thoughts? |
Contributor
|
sorry -- I was not doing heavy inspection of build logs for the workbench, but I see that we do not have it listed as build-dependency and never installed during package builds so most likely bundled copy was used indeed. Confirming that building against system wide is preferable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on a Fedora machine, I am unable to find the QuaZip library, when it is installed.
It appears that it needs to be found via
QuaZip-Qt*, and populates case-sensitive variables. This patch looks for the specific QuaZip for the version of QT that is being targeted.I do not know if this generalizes to other operating systems or depends on Linux/Fedora-specific configurations. I will be trying this patch in the conda-forge build as well.
Closes #61.
Closes #63.