This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Handle payments for Stripe Subscriptions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronelliotross
force-pushed
the
stripe-endpoint
branch
from
fb6203f to
b864f53
Compare
rthouvenin
reviewed
Feb 14, 2022
rthouvenin
reviewed
Feb 14, 2022
Contributor
rthouvenin
left a comment
rthouvenin
left a comment
There was a problem hiding this comment.
On potential other event types to support: I think the current webhook handles refunds (when we refund from Stripe UI after a complaint) and cancellations (on people's request and when the card expire). If we don't implement them anymore, the donation account needs to be informed.
aaronelliotross
force-pushed
the
stripe-endpoint
branch
from
7c5d434 to
e6e3781
Compare
aaronelliotross
force-pushed
the
stripe-endpoint
branch
from
8e82d7e to
12678ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So. The civicrm extension that we've been using for Stripe has been problematic. The code is complicated and very abstracted, so debugging is quite hard. I've given up trying to fix it.
Instead, I propose we start over with simple code that handles only the events we need. And makes lots of assumptions about the context - to simplify.
We'll add more events as we need them.
One question I have is if there are any other critical events to implement quickly?