Fix on_ground condition parsing, make blocks optional, add distanceFr…#28
Open
DMariusM wants to merge 3 commits intoWeaponMechanics:masterfrom
Open
Fix on_ground condition parsing, make blocks optional, add distanceFr…#28DMariusM wants to merge 3 commits intoWeaponMechanics:masterfrom
DMariusM wants to merge 3 commits intoWeaponMechanics:masterfrom
Conversation
Member
DMariusM
commented
Jan 11, 2026
DMariusM
commented
- blocks is now optional
- if the blocks list is empty, than the condition matches any block
- added an optional argument called distanceFromGround (default value is 0.01) that checks slightly below the feet to validate the blocks list
…omGround - blocks is now optional - if the blocks list is empty, than the condition matches any block - added an optional argument called distanceFromGround (default value is 0.01) that checks slightly below the feet to validate the blocks list
CJCrafter
requested changes
Jan 30, 2026
Member
CJCrafter
left a comment
CJCrafter
left a comment
There was a problem hiding this comment.
Minor changes, but looks good :)
mechanicscore-core/src/main/java/me/deecaad/core/mechanics/conditions/OnGroundCondition.java
Show resolved
Hide resolved
mechanicscore-core/src/main/java/me/deecaad/core/mechanics/conditions/OnGroundCondition.java
Outdated
Show resolved
Hide resolved
mechanicscore-core/src/main/java/me/deecaad/core/mechanics/conditions/OnGroundCondition.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.