fix(release): harden notary wait and ship short-alias sidecars only - #358
Merged
Conversation
Extend notary wait budget with per-slice timeouts and network backoff, raise submit upload timeout for ~1GB apps, pack only short sidecar aliases per target arch, and log afterPack resource sizes for release diagnostics.
github-actions
Bot
added
desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notarytool wait --timeout, network backoff, and 20m submit upload timeout for ~1GB apps.opencode/onmyagent-orchestrator/versions.json) so dual-arch triple copies never enter the installer.Why
Recent Release App failures (e.g. arm64 success / x64 fail) end with:
notarization did not complete within 60 minwhile Apple status is still In ProgressNSURLErrorDomain -1009) during waitnotarytool submit timed outNo recent failures show Apple Invalid/Rejected or missing codesign secrets when certs are present. arm64 notarized assets already land on
v0.5.3.Test plan
node --check apps/desktop/scripts/electron-after-sign.cjsnode --test apps/desktop/scripts/prune-bundled-runtime.test.mjsnotarize: true,prerelease: true, confirm arm64+x64 package steps succeed