fix(release): do not overwrite stapled macOS artifacts - #359
Merged
Conversation
The non-notarized package step ran after a successful notarize+staple and overwrote DMG/ZIP, so Gatekeeper reported Unnotarized Developer ID. Gate package steps on resolve-release notarize output and validate staple/spctl before upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needs.resolve-release.outputs.notarize(notenv.MACOS_NOTARIZE) so notarized and non-notarized paths cannot both run.stapler validate+spctlso we fail before uploading a broken ticket.Root cause
CI log for the successful-looking v0.5.3 run showed:
spctl→Unnotarized Developer ID,stapler validate→ no ticketTest plan
tag=v0.5.3 notarize=true prerelease=truespctl -a -vvaccepts,stapler validateOK