Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Feb 10, 2026

Motivation and Context

Jira Link:

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Note

Medium Risk
Adds a new JSON-RPC processing path and changes shared error serialization logic, which could affect middleware behavior and error shapes if adopted by consumers.

Overview
Introduces a new src/jrpc/v2 JSON-RPC engine and server API, including JsonRpcEngineV2, JsonRpcServer, and a frozen MiddlewareContext, with stricter semantics around request vs. notification handling, immutability, and middleware composition/destroy lifecycle.

Adds a V1↔V2 bridge via asLegacyMiddleware plus cloning/context propagation helpers, and updates error handling to better preserve/serialize cause data for JSON-RPC errors (with deterministic toString). Extensive new vitest coverage is added for the v2 engine/server, compatibility layer, and error serialization behavior.

Written by Cursor Bugbot for commit b3352a9. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Base automatically changed from fix/jrpc-errors to master February 11, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants