Migrate MetaMask Connector to use new SDK (MMConnect) by adonesky1 · Pull Request #2326 · Web3Auth/web3auth-web

adonesky1 · 2026-01-07T22:37:30Z

Summary

Migrate MetaMask integration from @metamask/sdk to @metamask/connect-evm for improved connection handling
Refactor MetaMaskConnector to use the new SDK's createEVMClient() API with built-in event handlers and automatic chain management
Remove manual chain addition logic as the new SDK handles this internally during switchChain()
Update connector settings interface to align with the new SDK's configuration options

Videos

Extension:
https://drive.google.com/file/d/1r_lDBvwHWQhP-J4yFfqVHsqRR7bIS6Z1/view?usp=sharing

Mobile (native browser):
https://drive.google.com/file/d/1XECLgCOqa9VEeIK4gp1nUf0cs6RRg2V1/view?usp=sharing

Note

Migrates EVM MetaMask integration to the new @metamask/connect-evm SDK and wires it into Web3AuthNoModal.

New metamaskConnector using createEVMClient() with built-in event handlers, CAIP-2 supportedNetworks, connect, disconnect, and switchChain (auto add/switch)
Web3AuthNoModal.loadConnectors() now adds metaMaskConnector() for EIP-155 chains (preferred over injected)
Bumps @web3auth/no-modal to 10.13.2; replaces @metamask/sdk with @metamask/connect-evm in package.json; updates related deps/locks

^{Written by Cursor Bugbot for commit 87da4b7. This will update automatically on new commits. Configure here.}

vercel · 2026-01-07T22:37:35Z

@adonesky1 is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

demo/vue-app-new/src/services/ethHandlers.ts

demo/vue-app-new/src/utils/constants.ts

jiexi · 2026-01-20T21:51:17Z

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

+      this.metamaskInstance = await this.metamaskPromise;
+      // TODO: Remove this hack
+      // Hack to ensure the ConnectEvm instance has fully resumed the connection
+      await new Promise((resolve) => setTimeout(resolve, 2000));


Note this awful delay to ensure that this async call in the ConnectEvm constructor has fully resolved. We need to fix this on the connect-monorepo side

What is your understanding of how we resolve this on the connect-evm side of things?

Ticket to resolve this here: https://consensyssoftware.atlassian.net/browse/WAPI-1035?atlOrigin=eyJpIjoiMjk1OGRjZjE3MjcwNDQyMzhjODdmMjU3MTMyMDdhMmEiLCJwIjoiaiJ9

we need to release connect-evm again, bump the version in web3auth, and then remove this setTimeout

jiexi · 2026-01-20T21:52:15Z

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

+      // if (options.autoConnect) {
+      //   this.rehydrated = false;
+      //   this.emit(CONNECTOR_EVENTS.REHYDRATION_ERROR, new Error("Failed to resume existing MetaMask Connect session.") as Web3AuthError);
+      // } else {


i think this commented code can be dropped?.. Not sure if it's more appropriate to throw an error if we fail to resume a previous session OR if we just say the connector is ready for new connections

I would think it makes more sense to just say the connector is ready for new connections. But perhaps we should speak with @chaitanyapotti to see what patterns they recommend for their connectors

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

jiexi · 2026-01-20T22:29:09Z

Need: MetaMask/connect-monorepo#124

jiexi · 2026-01-27T22:05:58Z

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

+/**
+ * Configuration options for the MetaMask connector using @metamask/connect-evm
+ */
+export interface MetaMaskConnectorSettings {
+  /** Dapp identification and branding settings */
+  dapp?: {
+    name?: string;
+    url?: string;
+  };
+  /** Enable debug logging for the MetaMask SDK */
+  debug?: boolean;
+}

 export interface MetaMaskConnectorOptions extends BaseConnectorSettings {
-  connectorSettings?: Partial<MetaMaskSDKOptions>;
+  connectorSettings?: MetaMaskConnectorSettings;


reminder to document this breaking change and include migration instructions where appropriate

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

cursor · 2026-01-27T23:31:05Z

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

+          "eip155:5": "https://goerli.infura.io/v3/demo",
+          "eip155:11155111": "https://sepolia.infura.io/v3/demo",
+          "eip155:137": "https://polygon-rpc.com",
+        },


User-configured RPC URLs are ignored in SDK initialization

High Severity

The code builds a supportedNetworks map from user-configured chains (lines 142-148) but this variable is never passed to createEVMClient(). Instead, hardcoded RPC endpoints are used (lines 167-174), meaning users' custom chain configurations and RPC URLs are silently ignored. Only mainnet, goerli, sepolia, and polygon will work with the hardcoded endpoints. The dynamically built supportedNetworks variable appears intended for use but was left as dead code.

I think this cursor comment is valid

tuna1207 · 2026-01-29T15:01:20Z

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

+    for (const chain of this.coreOptions.chains) {
+      // Convert hex chainId (0x1) to number for CAIP-2 format (eip155:1)
+      const numericChainId = parseInt(chain.chainId, 16);
+      const caipChainId = `eip155:${numericChainId}`;


we can use this ready made getCaipChainId util for getting caipChainId similar to

web3auth-web/packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

Line 134 in 3286675

chain_id: getCaipChainId(chainConfig),

chaitanyapotti · 2026-02-02T11:35:25Z

packages/no-modal/src/noModal.ts

-      // only set headless to true if modal SDK is used, otherwise just use the modal from native Metamask SDK
-      connectorFns.push(metaMaskConnector(modalMode ? { headless: true } : undefined));
+      // Note: The new @metamask/connect-evm SDK handles its own UI internally
+      connectorFns.push(metaMaskConnector());


we ideally can't use the metamask sdk ui since the ux would be very different. is there no option for headless mode?

chaitanyapotti · 2026-02-02T11:36:34Z

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

+    const appUrl = this.connectorSettings?.dapp?.url || window.location.origin || "https://web3auth.io";
+
+    // Initialize the MetaMask Connect EVM SDK
+    this.metamaskPromise = createEVMClient({


how do we support solana?

we should switch the client based on active chain / use multi-chain client and switch chain in this connector based on active chain in sdk

adonesky1 added 3 commits January 7, 2026 16:04

migrate metamask connector to new sdk

6fbe545

package update

159a350

wip

67013a6

adonesky1 marked this pull request as draft January 7, 2026 23:03

adonesky1 and others added 3 commits January 8, 2026 14:52

more working

8d67eaf

more working

52bafcb

Fix metamask connector

288a667

jiexi mentioned this pull request Jan 20, 2026

fix: Fix eth_chainId not being resolved from cache when using EIP-1193 Provider MetaMask/connect-monorepo#124

Merged

4 tasks

jiexi reviewed Jan 20, 2026

View reviewed changes

demo/vue-app-new/src/services/ethHandlers.ts Outdated Show resolved Hide resolved

jiexi reviewed Jan 20, 2026

View reviewed changes

demo/vue-app-new/src/utils/constants.ts Outdated Show resolved Hide resolved

jiexi reviewed Jan 20, 2026

View reviewed changes

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts Show resolved Hide resolved

jiexi and others added 10 commits January 22, 2026 12:44

use connect-evm 0.3.0

114cfbd

fix package lock

17e1c44

adopt ConnectEvm.status change

054ad3f

Merge remote-tracking branch 'origin' into ad/migrate-metamask-connector

f3ce613

update package-lock.json

ea7e070

connect-evm bump

dda7b97

package-lock

8e4a2c8

Merge remote-tracking branch 'origin' into ad/migrate-metamask-connector

0eac6bb

cleanup

b9c977a

more cleanup

24e210d

adonesky1 changed the title ~~Update metamask connector WIP~~ Migrate MetaMask Connector to use new SDK (MMConnect) Jan 23, 2026

adonesky1 marked this pull request as ready for review January 23, 2026 22:34

jiexi reviewed Jan 27, 2026

View reviewed changes

jiexi added 2 commits January 27, 2026 15:20

bump connect-evm 0.4.1

5379c92

remove timeout hack

87da4b7

cursor bot reviewed Jan 27, 2026

View reviewed changes

tuna1207 reviewed Jan 29, 2026

View reviewed changes

chaitanyapotti reviewed Feb 2, 2026

View reviewed changes

Conversation

adonesky1 commented Jan 7, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Videos

Uh oh!

vercel bot commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jiexi commented Jan 20, 2026

Uh oh!

jiexi Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 27, 2026

Choose a reason for hiding this comment

User-configured RPC URLs are ignored in SDK initialization

Uh oh!

tuna1207 Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adonesky1 commented Jan 7, 2026 •

edited by cursor bot

Loading

jiexi Jan 27, 2026 •

edited

Loading

tuna1207 Jan 29, 2026 •

edited

Loading