add errors for sfa key login + update sfa demo app #2374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link: https://consensyssoftware.atlassian.net/browse/W3APD-5323
Description
Issue
Resolution
Chore
How has this been tested?
Devrels tested this.
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Medium Risk
Changes login flow behavior when
useSFAKeyis enabled by logging out and throwing a new/clearersfaKeyNotFounderror, and upgrades the demo app to@web3auth/modalplus React 19—both could affect connection/rehydration behavior and compatibility.Overview
Improves error handling for SFA-key logins: when
useSFAKeyis enabled but the session lackscoreKitKey(e.g., default verifier), the auth connector now proactively logs out (if a session exists) and throwsWalletLoginError.sfaKeyNotFoundwith a clearer message instead of failing later with an invalid key.Updates the
vite-react-app-sfademo to use@web3auth/modal(instead of@web3auth/no-modal), switches the Google flow toconnectTo(WALLET_CONNECTORS.AUTH, ...), adds a basic “Login with Web3Auth” button, and adjusts Web3Auth config (newclientId,sapphire_devnet,useSFAKey: true). Also bumps React/ReactDOM to19.2.4and enableswindow.globalpolyfill inindex.html.Written by Cursor Bugbot for commit 214436f. This will update automatically on new commits. Configure here.