[NFC] Remove TypeUpdating::canHandleAsLocal#8490
Merged
Conversation
This method originally handled non-nullable types, which early in the design of Wasm GC could not be stored in locals. Now they can be stored in locals, so this function does nothing more than check if the type is concrete. The property that any type can be stored in locals is important enough that it is almost certain that all future WebAssembly extensions will preserve it, so canHandleAsLocal will probably never have a non-trivial implementation again. Remove this utility and simplify all its former users.
kripken
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method originally handled non-nullable types, which early in the design of Wasm GC could not be stored in locals. Now they can be stored in locals, so this function does nothing more than check if the type is concrete. The property that any type can be stored in locals is important enough that it is almost certain that all future WebAssembly extensions will preserve it, so canHandleAsLocal will probably never have a non-trivial implementation again. Remove this utility and simplify all its former users.