Fix OptimizeInstructions for general Cmpxchg expected types#8495
Merged
Fix OptimizeInstructions for general Cmpxchg expected types#8495
Conversation
OptimizeInstructions previously assumed incorrectly that the expected field of a StructCmpxchg would be a subtype of the accessed field type. In fact, it can be a supertype as long as it is a subtype of eq (or shared eq).
kripken
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptimizeInstructions previously assumed incorrectly that the expected field of a StructCmpxchg would be a subtype of the accessed field type. In fact, it can be a supertype as long as it is a subtype of eq (or shared eq).