Merged
Conversation
We were missing a few type constraints for cont.bind. Add them, and also add more thorough tests for all the stack switching instructions, including the cases where the continuations are null. As a drive-by to get these tests working, fix the parsing of resume and resume_throw* to set the proper type arity when the input is null.
kripken
approved these changes
Mar 23, 2026
src/wasm-builder.h
Outdated
| ret->sentTypes.set(sentTypes); | ||
| ret->operands = std::move(operands); | ||
| ret->cont = cont; | ||
| assert(contType.isContinuation()); |
Member
There was a problem hiding this comment.
the line below will assert on this
Suggested change
| assert(contType.isContinuation()); |
src/wasm-builder.h
Outdated
| ret->sentTypes.set(sentTypes); | ||
| ret->operands = std::move(operands); | ||
| ret->cont = cont; | ||
| assert(contType.isContinuation()); |
Member
There was a problem hiding this comment.
Suggested change
| assert(contType.isContinuation()); |
| (func $resume-throw-ref | ||
| (local $sub (ref null $sub)) | ||
| ;; This does NOT require $sub <: $super because we turn this into a | ||
| ;; `resume $sub`. |
Member
There was a problem hiding this comment.
Suggested change
| ;; `resume $sub`. | |
| ;; `resume_throw $sub`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing a few type constraints for cont.bind. Add them, and also add more thorough tests for all the stack switching instructions, including the cases where the continuations are null. As a drive-by to get these tests working, fix the parsing of resume and resume_throw* to set the proper type arity when the input is null.