Closed
Conversation
Collaborator
|
Upon reflection about #725, I actually think it'd be best to go in a different direction. WDYT about merging I'd like to by-default share things and we can split helpers out if necessary, but I think there's going to be a lot more shared code than not in the structure of these files. |
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
de1a080 to
e6b0088
Compare
alexcrichton
pushed a commit
that referenced
this pull request
Feb 24, 2026
Merge TCP implementations in `tcp.c` as suggested in #745 (comment) --------- Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Collaborator
|
As a heads up if you're out of time on this @rvolosatovs I've done some work in #750 to resolve merge conflicts and address some thoughts of mine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
fcntlEventually, we should unify the UDP implementations (#728 (review)). If most other socket-related PRs are merged, I might tackle this next week Monday, otherwise it seems that doing so now would introduce quite a bit of churn.
This is blocked on #725
Unfortunately, due to the way
sockets-nonblocking-udpis set up we cannot implement support for UDP just insocketand nowhere else, so bring along some fairly trivial UDP logic from wasip2 and introduce anabort()inpollfor now.wasi-libc/test/src/sockets-nonblocking-udp.c
Lines 37 to 38 in d974bce