Changes to support ARM64 including cross-compilation on linux#228
Merged
iangrunert merged 2 commits intomainfrom Apr 10, 2026
Merged
Changes to support ARM64 including cross-compilation on linux#228iangrunert merged 2 commits intomainfrom
iangrunert merged 2 commits intomainfrom
Conversation
…mpilation Add libwebp 1.6.0 and zlib-ng 2.3.3 ports needed for Windows ARM64 builds. Update ICU portfile and patches for cross-compiling MSVC from Linux. Add arm64-windows-webkit triplet. Consolidate the ICU patch files to one for cross-compilation, and one for pkgdata.cpp. Strip now unused CMAKE_CROSSCOMPILING_EMULATOR changes - we're no longer using wine, instead we build the local ICU tools and use those. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
foopoiuyt
approved these changes
Apr 10, 2026
Contributor
foopoiuyt
left a comment
foopoiuyt
left a comment
There was a problem hiding this comment.
LGTM
I'm assuming the Linux build of the ICU host tools isn't too expensive such that we'd want to only build on changes.
Contributor
Author
|
Yeah it's not too bad; they also only get built if ICU gets rebuilt and most of the time vcpkg doesn't change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes you can build the Windows port from Mac hardware using the webkit-container-sdk images.
I opted to consolidate ICU patches as part of this, instead of patching patches.
This drops the wine requirement for cross compilation - instead we build the ICU package tools for the host, and use those. This was necessary to build via Linux Docker containers on Mac - wine doesn't work in that environment unfortunately. This meant we could drop the CMAKE_CROSSCOMPILING_EMULATOR changes. No wine requirement makes the Linux cross compile much simpler.
The libwebp port is the same as the upstream plus a single patch 0010-fix-clang-cl-simd.patch.
The zlib-ng port is necessary for a similar simd patch.