Conversation
iangrunert
force-pushed
the
ig/update-server-2025
branch
3 times, most recently
from
14f0264 to
ccaca0a
Compare
donny-dont
left a comment
donny-dont
left a comment
There was a problem hiding this comment.
I think it's great that you figured out a way to get the Windows Server 2025 images building! I don't think at this time the Windows Server 2022 images can be jettisoned.
@foopoiuyt can be the final say there since I'm not doing any WebKit work currently. Only other thing I would request is to squash everything before landing.
| run: docker build --tag webkitdev/tools:${{ matrix.tag }} --build-arg IMAGE_TAG=${{ matrix.tag }} tools | ||
| - name: Build webkitdev/msbuild-2022 | ||
| run: docker build --tag webkitdev/msbuild-2022:${{ matrix.tag }} --build-arg IMAGE_TAG=${{ matrix.tag }} msbuild-2022 | ||
| - name: Build webkitdev/msbuild-vs2022 |
There was a problem hiding this comment.
I don't see a reason for renaming msbuild-2022 to msbuild-vs2022.
There was a problem hiding this comment.
Main reason was confusion between server 2022 and visual studio 2022, but I'm happy to revert that.
There was a problem hiding this comment.
Ah ok. Maybe vs2022-build-tools or something? @foopoiuyt do you have a preference?
| - tag: 2022 | ||
| os: windows-2022 | ||
| - tag: windows-2022 | ||
| os: windows-2022 |
There was a problem hiding this comment.
We base our internal images off of the windows-2022 tag so I would prefer these not be removed. Especially since we aren't paying for the CI time.
Remove Windows Server 2019, which didn't have automated CI Docker builds. Free up disk space on the actions runner, we were running out of disk while building images.
iangrunert
force-pushed
the
ig/update-server-2025
branch
from
ccaca0a to
186ed09
Compare
|
I re-added the 2022 images; I did check with @foopoiuyt first on the WebKit slack but I think it'll be easier to leave them in here for now. |
foopoiuyt
left a comment
foopoiuyt
left a comment
There was a problem hiding this comment.
This seems good to me. Keeping the 2022 gives us a bit more lead time for making the changes for internal images, but we'll try to see how quickly we can get off.
3 participants
Remove older images (Windows Server 2022, 2019) to simplify maintenance and make it clearer what's supported / automated.
Fixes #454 - the newer SDK doesn't work with Windows Server 2022 under Hyper-V isolation.