Handle read.table errors safely when subs.data is present in GetWTandMutCount#20
Open
sanroman-24 wants to merge 1 commit into
Open
Handle read.table errors safely when subs.data is present in GetWTandMutCount#20sanroman-24 wants to merge 1 commit into
sanroman-24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error handling for reading input data from loci_file.
Previously, the code used tryCatch(..., error = function(e) NA) and checked if (is.na(subs.data)) to detect failed reads. However, when subs.data is a matrix or data frame, is.na() returns a matrix of logicals, causing conditional checks to fail with an error (the condition has length > 1).
To address this, the code now returns NULL on read errors and checks for is.null(subs.data) instead. This approach is cleaner, safer, and avoids ambiguity when subs.data is a matrix.
Changes
Updated tryCatch to use error = function(e) NULL instead of returning NA.
Replaced if (is.na(subs.data)) with if (is.null(subs.data)).