Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore consistent split-view sidebar behavior on newer macOS versions by disabling the system “floating sidebar” appearance and adjusting window/sidebar styling in the main split-view UI.
Changes:
- Adds an explicit
main.swiftentry point to setNSSplitViewItemSidebarDefaultsToFloatingAppearance = falsebefore app initialization. - Simplifies the sidebar view hierarchy (removes the custom visual-effect wrapper) and introduces runtime window/detail-pane styling updates.
- Adds AppKit extensions to support layer-backed background colors and appearance-resolved colors.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| WhatCopiedMac/Sources/Controllers/MainVC+UI.swift | Removes the custom effect-view sidebar wrapper and adds updateSidebarStyle() to tweak window/background styling. |
| WhatCopiedMac/Sources/Controllers/MainVC.swift | Observes main-window state changes and triggers sidebar/window style updates during layout and window-main transitions. |
| WhatCopiedMac/Sources/AppDesign.swift | Removes the modernEffectView selection logic (no longer used by the sidebar). |
| WhatCopiedMac/Sources/AppDelegate.swift | Removes @main usage and moves the NSMenu swizzle out of launch to the new entry point. |
| WhatCopiedMac/Modules/Sources/AppKitExtensions/NSView+Extension.swift | Adds helpers for layer background color and descendant traversal. |
| WhatCopiedMac/Modules/Sources/AppKitExtensions/NSColor+Extension.swift | Adds a helper intended to resolve dynamic colors for appearance (currently conflicts with AppKit API). |
| WhatCopiedMac/main.swift | New app entry point that sets the sidebar-floating default and applies the NSMenu crash workaround before launch. |
| WhatCopied.xcodeproj/project.pbxproj | Adds main.swift to the app target’s sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple introduced "floating sidebar" in macOS 26 and deprecated that in macOS 27, disable manually to keep the experience consistent.