Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SF Symbol icons to the pasteboard picker entries and includes macOS 26/27-specific workarounds to keep the UI aligned and to restore menu item images on macOS 27.
Changes:
- Update the pasteboard
Pickerrows to include a symbol icon + title formatting, plus a control size tweak. - Add
NSPasteboard.iconNameto map known pasteboards to SF Symbols. - Add an
NSMenuItemswizzle (enabled on macOS 27+) to force menu item images visible for SwiftUI picker menus.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| WhatCopiedMac/Sources/Views/PickerView.swift | Renders picker rows with icons and adds a macOS 26-only spacing alignment workaround. |
| WhatCopiedMac/Sources/Extensions/NSMenuItem+Extension.swift | Adds a macOS 27+ preferredImageVisibility swizzle to restore SwiftUI Picker images. |
| WhatCopiedMac/Modules/Sources/AppKitExtensions/NSPasteboard+Extension.swift | Introduces iconName to choose SF Symbols per pasteboard type. |
| WhatCopiedMac/main.swift | Enables the new NSMenuItem swizzle on macOS 27+. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds icons to the pasteboard picker, with a few explained tricks for macOS 26 and 27.