Migrate to native Temporal - #98
Open
WickyNilliams wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Tests failing is expecting since they run in Chrome and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
Temporalhas landed in Firefox, I wanted to see the effect of removing Cally's minimalTemporalpolyfill and switching to the native implementation.There were a few places where my implementation was incorrect, so had to fix those up. And typescript still doesn't have the types, so I fudged some global types.
But it works!
So it saves around 1kb minified, and 0.5kb gzip. Not a huge amount. But I want Cally to be as small as possible, so I'm happy with that