user wont be logged in before migration ends#2537
Open
ludwikkazmierczak wants to merge 2 commits intomasterfrom
Open
user wont be logged in before migration ends#2537ludwikkazmierczak wants to merge 2 commits intomasterfrom
ludwikkazmierczak wants to merge 2 commits intomasterfrom
Conversation
WikiaTech
reviewed
Jan 8, 2019
| article.verifyUserLoggedIn(credentials.userName10); | ||
| // Caused by: https://wikia-inc.atlassian.net/browse/PLATFORM-3829 | ||
| // User wont be logged in after the migration is finished, since we are not going to sync access token over in CNW | ||
| // TODO: Enable once wikia.com -> fandom.com migration is complete |
There was a problem hiding this comment.
There was a problem hiding this comment.
@ludwikkazmierczak to repo przetrwalo sporo dluzej niz moglem sadzic, ale widze ze juz umarlo :D
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
WikiaTech
reviewed
Jan 8, 2019
| // Caused by: https://wikia-inc.atlassian.net/browse/PLATFORM-3829 | ||
| // User wont be logged in after the migration is finished, since we are not going to sync access token over in CNW | ||
| // TODO: Enable once wikia.com -> fandom.com migration is complete | ||
| // article.verifyUserLoggedIn(credentials.userName10); |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.