move external declarations to top level of rollup config#159
Open
nickolas1 wants to merge 1 commit intoWildhoney:masterfrom
Open
move external declarations to top level of rollup config#159nickolas1 wants to merge 1 commit intoWildhoney:masterfrom
nickolas1 wants to merge 1 commit intoWildhoney:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the external declarations need to be at the top level of the config to take effect, not in each output config. I'm not familiar enough with why the cjs build has clipper-lib external as well, so I moved that to a separate configuration. This should address #157.